Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: sleep when throttled (KIP-219) #2536

Merged
merged 2 commits into from
Aug 1, 2023
Merged

feat: sleep when throttled (KIP-219) #2536

merged 2 commits into from
Aug 1, 2023

Conversation

hindessm
Copy link
Collaborator

@hindessm hindessm commented Aug 1, 2023 •
edited by dnwe
Loading

This is a fairly simple approach to implement KIP-219, but I couldn't think of any reason why it shouldn't be sufficient.

@hindessm
feat: support for sleeping when throttled
5ac5dc0 
Signed-off-by: Mark Hindess <mark.hindess@gmail.com>
@hindessm
test: add throttling support test
102513a 
Signed-off-by: Mark Hindess <mark.hindess@gmail.com>
@dnwe dnwe added the feat label Aug 1, 2023
dnwe
dnwe approved these changes Aug 1, 2023
View reviewed changes
Copy link
Collaborator

@dnwe dnwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, changes look good to me after re-reading KIP-219 and walking through the code

@dnwe dnwe merged commit 87209f8 into IBM:main Aug 1, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnwe dnwe dnwe approved these changes

Assignees
No one assigned
Labels
feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hindessm @dnwe